netdev - Re: [PATCH net v2 1/3] net: ethernet: mtk_eth_soc: fix flow block refcounting logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230330183840.GW831478@unreal>
Date:   Thu, 30 Mar 2023 21:38:40 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Felix Fietkau <nbd@....name>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net v2 1/3] net: ethernet: mtk_eth_soc: fix flow block
 refcounting logic

On Thu, Mar 30, 2023 at 02:08:38PM +0200, Felix Fietkau wrote:
> Since we call flow_block_cb_decref on FLOW_BLOCK_UNBIND, we also need to
> call flow_block_cb_incref for a newly allocated cb.
> Also fix the accidentally inverted refcount check on unbind.
> 
> Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Signed-off-by: Felix Fietkau <nbd@....name>
> ---
>  drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>