netdev - Re: [PATCH net] net: stmmac: fix up RX flow hash indirection table when setting channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Mar 2023 21:46:16 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Corinna Vinschen <vinschen@...hat.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: stmmac: fix up RX flow hash indirection table
 when setting channels

On Fri, 31 Mar 2023 11:23:47 +0200 Corinna Vinschen wrote:
>  	priv->plat->rx_queues_to_use = rx_cnt;
>  	priv->plat->tx_queues_to_use = tx_cnt;
> +	for (i = 0; i < ARRAY_SIZE(priv->rss.table); i++)
> +		priv->rss.table[i] = ethtool_rxfh_indir_default(i, rx_cnt);

You need to check if (!netif_is_rxfh_configured())
if user set the config to not RSS to all queues we shouldn't reset.