netdev - Re: [PATCH net-next 1/4] ice: define metadata to match in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCfzIx5fKcDKHoso@corigine.com>
Date:   Sat, 1 Apr 2023 11:02:27 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        wojciech.drewek@...el.com, piotr.raczynski@...el.com
Subject: Re: [PATCH net-next 1/4] ice: define metadata to match in switch

On Fri, Mar 31, 2023 at 12:57:44PM +0200, Michal Swiatkowski wrote:
> Add description for each metadata. Redefine tunnel mask to match only
> tunneled MAC and tunneled VLAN. It shouldn't try to match other flags
> (previously it was 0xff, it is redundant).
> 
> VLAN mask was 0xd000, change it to 0xf000. 4 last bits are flags
> depending on the same field in packets (VLAN tag). Because of that,
> It isn't harmful to match also on ITAG.
> 
> Group all MDID and MDID offsets into enums to keep things organized.
> 
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>

...

> + * MDID 23
> + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> + * |A|B|C|D|        R        |E|F|R|
> + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> + *
> + * A = MAC error - Produced by MAC according to L2 error conditions
> + * B = PPRS no offload - FIFO overflow in PPRS or any problematic condition in
> + *			 PPRS ANA
> + * C = abort - Set when malicious packet is detected
> + * D = partial analize - ANA's analyzing got cut in the middle

nit: checkpatch.pl --codespell tells me that 'analize' is misspelt