netdev - Re: [PATCH net-next 2/4] ice: remove redundant Rx field from rule info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCfzXuoLHxoxqa/C@corigine.com>
Date:   Sat, 1 Apr 2023 11:03:26 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        wojciech.drewek@...el.com, piotr.raczynski@...el.com
Subject: Re: [PATCH net-next 2/4] ice: remove redundant Rx field from rule
 info

On Fri, Mar 31, 2023 at 12:57:45PM +0200, Michal Swiatkowski wrote:
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
> 
> Setting direction flag doesn't mean that there is a match criteria for
> direction in rule. It is only a information for HW from where switch id
> should be collected (VSI or port). In current implementation of advance
> rule handling, without matching for direction metadata, we can always
> set one the same flag and everything will work the same.
> 
> Ability to match on direction matadata will be added in follow up
> patches.

nit: checkpatch.pl --codespell tells me that 'matadata' is misspelt

> 
> Recipe 0, 3 and 9 loaded from package has direction match
> criteria, but they are handled in other function.
> 
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>