netdev - Re: [PATCH v8 net-next 05/14] pds_core: set up device and adminq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf47c976-2714-62b7-3e5e-436fcfc788d4@amd.com>
Date:   Sat, 1 Apr 2023 12:48:33 -0700
From:   Shannon Nelson <shannon.nelson@....com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     brett.creeley@....com, davem@...emloft.net, netdev@...r.kernel.org,
        drivers@...sando.io, leon@...nel.org, jiri@...nulli.us
Subject: Re: [PATCH v8 net-next 05/14] pds_core: set up device and adminq

On 3/31/23 10:07 PM, Jakub Kicinski wrote:
> 
> On Thu, 30 Mar 2023 16:46:19 -0700 Shannon Nelson wrote:
>> +     listlen = fw_list.num_fw_slots;
>> +     for (i = 0; i < listlen; i++) {
>> +             snprintf(buf, sizeof(buf), "fw.%s",
>> +                      fw_list.fw_names[i].slotname);
>> +             err = devlink_info_version_stored_put(req, buf,
>> +                                                   fw_list.fw_names[i].fw_version);
>> +     }
> 
> Keys must be enumerated in the kernel, no copying directly from
> the FW please.

Sure - I can stick the name strings here as I see in a couple other drivers.

> 
> Also it'd be a little easier to review if the documentation was part
> of the same patch as code :(

Well, at least there is a doc file at the end of the patchset :-). 
Shall I build up the pds_core.rst file little by little throughout the 
patchset?

sln