netdev - Re: [PATCH v8 net-next 07/14] pds_core: add FW update feature to devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e775522-db04-f187-1f40-c7ecb1b8e5a6@amd.com>
Date:   Sat, 1 Apr 2023 12:49:28 -0700
From:   Shannon Nelson <shannon.nelson@....com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     brett.creeley@....com, davem@...emloft.net, netdev@...r.kernel.org,
        drivers@...sando.io, leon@...nel.org, jiri@...nulli.us
Subject: Re: [PATCH v8 net-next 07/14] pds_core: add FW update feature to
 devlink

On 3/31/23 10:09 PM, Jakub Kicinski wrote:
> 
> On Thu, 30 Mar 2023 16:46:21 -0700 Shannon Nelson wrote:
>> Add in the support for doing firmware updates.  Of the two
>> main banks available, a and b, this updates the one not in
>> use and then selects it for the next boot.
> 
> My memory is hazy but I think you needed similar functionality in ionic
> and deferred implementing proper uAPI for it? And now we have another
> driver with the same problem?

I don't believe we discussed bank selection for ionic, but did in a 
follow up discussion from the original posting of this driver back in 
November [1].  This expanded into a much large thing that no one has 
gotten around to working on yet.  At this point we simply are installing 
the new FW and waiting for a reboot to make it live, which I don't 
remember causing any controversy in ionic.

In the ionic case, we did have a short discussion about nomenclature for 
select and enable, and reworked the timeout status notification.  This 
code uses those same methods.

sln

[1] https://lore.kernel.org/netdev/20221212103450.6a747114@kernel.org/