netdev - Re: [PATCH net-next RFC] Add NDOs for hardware timestamp get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230402165656.h5v43cnxdsctkire@skbuf>
Date:   Sun, 2 Apr 2023 19:56:56 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Max Georgiev <glipus@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, kory.maincent@...tlin.com,
        netdev@...r.kernel.org, maxime.chevallier@...tlin.com
Subject: Re: [PATCH net-next RFC] Add NDOs for hardware timestamp get/set

On Sun, Apr 02, 2023 at 08:28:08AM -0600, Max Georgiev wrote:
> On Sat, Apr 1, 2023 at 2:18 PM Vladimir Oltean <vladimir.oltean@....com> wrote:
> >
> > On Sat, Apr 01, 2023 at 12:24:50PM -0700, Jakub Kicinski wrote:
> > > It should be relatively easy to plumb both the ifr and the in-kernel
> > > config thru all the DSA APIs and have it call the right helper, too,
> > > tho? SMOC?
> >
> > Sorry, this does not compute.
> >
> > "Plumbing the in-kernel config thru all the DSA APIs" would be the
> > netdev notifier that I proposed one year ago. I just need you to say
> > "yes, sounds ok, let's see how that looks with last year's feedback
> > addressed".
> 
> I sent out a second iteration of the ndo_hwtstamp_get/set patch.
> I tried to address all the comments except fixing DSA API - I still
> don't have a full understanding of what is the plan there.

Well, my plan is for this patch set (to which you were copied before
sending out your v2) to be merged, then you could see what remains to be
done on top of that, and that should be easy-peasy:
https://patchwork.kernel.org/project/netdevbpf/cover/20230402123755.2592507-1-vladimir.oltean@nxp.com/

I think that patch set explains quite clearly what's with DSA's API and
what I intend it to become.