netdev - Re: [PATCH net-next 1/7] net: don't abuse "default" case for unknown ioctl in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5892d30c-0a07-7696-8e67-d5f5a1d77183@gmail.com>
Date:   Sun, 2 Apr 2023 05:46:57 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Maxim Georgiev <glipus@...il.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Köry Maincent <kory.maincent@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 1/7] net: don't abuse "default" case for unknown
 ioctl in dev_ifsioc()



On 4/2/2023 5:37 AM, Vladimir Oltean wrote:
> The "switch (cmd)" block from dev_ifsioc() gained a bit too much
> unnecessary manual handling of "cmd" in the "default" case, starting
> with the private ioctls.
> 
> Clean that up by using the "ellipsis" gcc extension, adding separate
> cases for the rest of the ioctls, and letting the default case only
> return -EINVAL.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian