netdev - Re: [PATCH net-next 2/7] net: simplify handling of dsa_ndo_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f6cbe87-4fc1-9eb2-4c0b-ab790c2c7297@gmail.com>
Date:   Sun, 2 Apr 2023 05:47:32 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Maxim Georgiev <glipus@...il.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Köry Maincent <kory.maincent@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 2/7] net: simplify handling of
 dsa_ndo_eth_ioctl() return code



On 4/2/2023 5:37 AM, Vladimir Oltean wrote:
> In the expression "x == 0 || x != -95", the term "x == 0" does not
> change the expression's logical value, because 0 != -95, and so,
> if x is 0, the expression would still be true by virtue of the second
> term. If x is non-zero, the expression depends on the truth value of
> the second term anyway. As such, the first term is redundant and can
> be deleted.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian