netdev - Re: [PATCH net-next 3/7] net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP ioctls to dedicated handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <915c64ca-bbea-bfe9-3898-cd65791c3e5d@gmail.com>
Date:   Sun, 2 Apr 2023 05:52:29 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Maxim Georgiev <glipus@...il.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Köry Maincent <kory.maincent@...tlin.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next 3/7] net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP
 ioctls to dedicated handlers



On 4/2/2023 5:37 AM, Vladimir Oltean wrote:
> DSA does not want to intercept all ioctls handled by dev_eth_ioctl(),
> only SIOCSHWTSTAMP. This can be seen from commit f685e609a301 ("net:
> dsa: Deny PTP on master if switch supports it"). However, the way in
> which the dsa_ndo_eth_ioctl() is called would suggest otherwise.
> 
> Split the handling of SIOCSHWTSTAMP and SIOCGHWTSTAMP ioctls into
> separate case statements of dev_ifsioc(), and make each one call its own
> sub-function. This also removes the dsa_ndo_eth_ioctl() call from
> dev_eth_ioctl(), which from now on exclusively handles PHY ioctls.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

PS: there could be some interesting use cases with SIO(S|G)MII(REG|PHY) 
to be explored, but not for now.
-- 
Florian