netdev - Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: fix ppe flow accounting for L2 flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Apr 2023 15:53:58 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Felix Fietkau <nbd@....name>
Cc:     netdev@...r.kernel.org, Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH net-next 2/3] net: ethernet: mtk_eth_soc: fix ppe flow
 accounting for L2 flows

On Fri, Mar 31, 2023 at 10:29:44AM +0200, Felix Fietkau wrote:
> For L2 flows, the packet/byte counters should report the sum of the
> counters of their subflows, both current and expired.
> In order to make this work, change the way that accounting data is tracked.
> Reset counters when a flow enters bind. Once it expires (or enters unbind),
> store the last counter value in struct mtk_flow_entry.
> 
> Fixes: 3fbe4d8c0e53 ("net: ethernet: mtk_eth_soc: ppe: add support for flow accounting")
> Signed-off-by: Felix Fietkau <nbd@....name>
> ---
>  drivers/net/ethernet/mediatek/mtk_ppe.c       | 137 ++++++++++--------
>  drivers/net/ethernet/mediatek/mtk_ppe.h       |   8 +-
>  .../net/ethernet/mediatek/mtk_ppe_debugfs.c   |   2 +-
>  .../net/ethernet/mediatek/mtk_ppe_offload.c   |  17 +--
>  4 files changed, 88 insertions(+), 76 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>