netdev - Re: [PATCH net-next 3/6] net: txgbe: Add SFP module identify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6afd3b3-c31c-46c6-96f2-a34d1e92c107@lunn.ch>
Date:   Mon, 3 Apr 2023 14:58:32 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiawen Wu <jiawenwu@...stnetic.com>
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk,
        mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next 3/6] net: txgbe: Add SFP module identify

> +Identifying Adapter
> +===================
> +The driver is compatible with WangXun Sapphire Dual ports Ethernet Adapters.
> +
> +SFP+ Devices with Pluggable Optics
> +----------------------------------
> +The following is a list of 3rd party SFP+ modules that have been tested and verified.
> +
> ++----------+----------------------+----------------------+
> +| Supplier | Type                 | Part Numbers         |
> ++==========+======================+======================+
> +| ACCELINK | SFP+                 | RTXM228-551          |
> ++----------+----------------------+----------------------+
> +| Avago	   | SFP+                 | SFBR-7701SDZ         |
> ++----------+----------------------+----------------------+

Tab issue.

> +| BOYANG   | SFP+                 | OMXD30000            |
> ++----------+----------------------+----------------------+
> +| F-tone   | SFP+                 | FTCS-851X-02D        |
> ++----------+----------------------+----------------------+
> +| FS       | SFP+                 | SFP-10GSR-85         |
> ++----------+----------------------+----------------------+
> +| Finisar  | SFP+                 | FTLX8574D3BCL        |
> ++----------+----------------------+----------------------+
> +| Hisense  | SFP+                 | LTF8502-BC+          |
> ++----------+----------------------+----------------------+
> +| HGTECH   | SFP+                 | MTRS-01X11-G         |
> ++----------+----------------------+----------------------+
> +| HP       | SFP+                 | SR SFP+ 456096-001   |
> ++----------+----------------------+----------------------+
> +| Huawei   | SFP+                 | AFBR-709SMZ          |
> ++----------+----------------------+----------------------+
> +| Intel    | SFP+                 | FTLX8571D3BCV-IT     |
> ++----------+----------------------+----------------------+
> +| JDSU     | SFP+                 | PLRXPL-SC-S43        |
> ++----------+----------------------+----------------------+
> +| SONT     | SFP+                 | XP-8G10-01           |
> ++----------+----------------------+----------------------+
> +| Trixon   | SFP+                 | TPS-TGM3-85DCR       |
> ++----------+----------------------+----------------------+

This does not make much sense, now that the generic SFP driver is
being used. If you want to have a such a list, move it into the
generic SFP documentation.

I assume you have retested all these using the generic code?

Russell will be interested in the contents of the EEPROM for these. 

> +Laser turns off for SFP+ when ifconfig ethX down
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +"ifconfig ethX down" turns off the laser for SFP+ fiber adapters.
> +"ifconfig ethX up" turns on the laser.

This also not specific to your device, the generic SFP code will do
that.

> +static int txgbe_sfp_register(struct txgbe *txgbe)
> +{
> +	struct pci_dev *pdev = txgbe->wx->pdev;
> +	struct platform_device_info info;
> +	struct platform_device *sfp_dev;
> +
> +	memset(&info, 0, sizeof(info));

I _think_ the memset can be replace by

struct platform_device_info info = {};

       Andrew