netdev - RE: [PATCH] net: fec: make use of MDIO C45 quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR04MB31391F3638611D67EEC1DC3488939@AM5PR04MB3139.eurprd04.prod.outlook.com>
Date:   Tue, 4 Apr 2023 06:05:19 +0000
From:   Wei Fang <wei.fang@....com>
To:     Greg Ungerer <gerg@...ux-m68k.org>
CC:     Shenwei Wang <shenwei.wang@....com>,
        Clark Wang <xiaoning.wang@....com>,
        dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>
Subject: RE: [PATCH] net: fec: make use of MDIO C45 quirk

> -----Original Message-----
> From: Greg Ungerer <gerg@...ux-m68k.org>
> Sent: 2023年4月4日 13:22
> To: Wei Fang <wei.fang@....com>
> Cc: Shenwei Wang <shenwei.wang@....com>; Clark Wang
> <xiaoning.wang@....com>; dl-linux-imx <linux-imx@....com>;
> netdev@...r.kernel.org; andrew@...n.ch; Greg Ungerer
> <gerg@...ux-m68k.org>
> Subject: [PATCH] net: fec: make use of MDIO C45 quirk
> 
> Not all fec MDIO bus drivers support C45 mode transactions. The older fec
> hardware block in many ColdFire SoCs does not appear to support them, at
> least according to most of the different ColdFire SoC reference manuals.
> The bits used to generate C45 access on the iMX parts, in the OP field of the
> MMFR register, are documented as generating non-compliant MII frames (it is
> not documented as to exactly how they are non-compliant).
> 
> Commit 8d03ad1ab0b0 ("net: fec: Separate C22 and C45 transactions") means
> the fec driver will always register c45 MDIO read and write methods. During
> probe these will always be accessed now generating non-compliant MII
> accesses on ColdFire based devices.
> 
> Add a quirk define, FEC_QUIRK_HAS_MDIO_C45, that can be used to
> distinguish silicon that supports MDIO C45 framing or not. Add this to all the
> existing iMX quirks, so they will be behave as they do now (*).
> 
> (*) it seems that some iMX parts may not support C45 transactions either.
>     The iMX25 and iMX50 Reference Manuals contain similar wording to
>     the ColdFire Reference Manuals on this.
> 
> Fixes: 8d03ad1ab0b0 ("net: fec: Separate C22 and C45 transactions")
> Signed-off-by: Greg Ungerer <gerg@...ux-m68k.org>

It looks good to me.
Reviewed-by: Wei Fang <wei.fang@....com>