netdev - Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04288ea7-a9d5-6a79-b0f7-fd2a714af8f5@leemhuis.info>
Date:   Wed, 5 Apr 2023 13:16:34 +0200
From:   "Linux regression tracking #update (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Ricardo Cañuelo <ricardo.canuelo@...labora.com>,
        Rafał Miłecki <zajec5@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jon Mason <jon.mason@...adcom.com>, netdev@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>,
        Jon Mason <jdmason@...zu.us>
Subject: Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358

On 04.04.23 15:46, Ricardo Cañuelo wrote:
>
> On mar 07-02-2023 23:53:27, Rafał Miłecki wrote:
>> While bringing hardware up we should perform a full reset including the
>> switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what
>> specification says and what reference driver does.
>>
>> This seems to be critical for the BCM5358. Without this hardware doesn't
>> get initialized properly and doesn't seem to transmit or receive any
>> packets.
>>
>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> 
> KernelCI found this patch causes a regression in the
> bootrr.deferred-probe-empty test [1] on sun8i-h3-libretech-all-h3-cc
> [2], see the bisection report for more details [3]
> 
> Does it make sense to you?
> 
> Cheers,
> Ricardo
> 
> [1] https://github.com/kernelci/bootrr/blob/3ae9fd5dffc667fa96012892ea08532bc6877276/helpers/bootrr-generic-tests#L3
> [2] https://linux.kernelci.org/test/case/id/642a0f5c78c0feaf5d62f79c/
> [3] https://groups.io/g/kernelci-results/message/40156
> 
> #regzbot introduced: f6a95a24957a

Thx for telling regzbot about this. It seems something went wrong here,
the patch this thread about is f99e6d7c4ed3 (which contains a Fixes: tag
for f6a95a24957a); copy and paste mistake maybe, whatever.

Fixing this and while at it giving this a better title:

#regzbot introduced: f99e6d7c4ed3
#regzbot title: net: bgmac: bootrr.deferred-probe-empty test fails in
KernelCi on sun8i-h3-libretech-all-h3-cc
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
That page also explains what to do if mails like this annoy you.