netdev - Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7b11a57-9512-cda9-1b15-5dd5aa12f162@gmail.com>
Date:   Wed, 5 Apr 2023 05:42:59 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rafał Miłecki <rafal@...ecki.pl>,
        Ricardo Cañuelo <ricardo.canuelo@...labora.com>,
        Rafał Miłecki <zajec5@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Jon Mason <jdmason@...zu.us>
Subject: Re: [PATCH net] bgmac: fix *initial* chip reset to support BCM5358



On 4/4/2023 6:52 AM, Rafał Miłecki wrote:
> Hi,
> 
> On 4.04.2023 15:46, Ricardo Cañuelo wrote:
>> On mar 07-02-2023 23:53:27, Rafał Miłecki wrote:
>>> While bringing hardware up we should perform a full reset including the
>>> switch bit (BGMAC_BCMA_IOCTL_SW_RESET aka SICF_SWRST). It's what
>>> specification says and what reference driver does.
>>>
>>> This seems to be critical for the BCM5358. Without this hardware doesn't
>>> get initialized properly and doesn't seem to transmit or receive any
>>> packets.
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
>>
>> KernelCI found this patch causes a regression in the
>> bootrr.deferred-probe-empty test [1] on sun8i-h3-libretech-all-h3-cc
>> [2], see the bisection report for more details [3]
>>
>> Does it make sense to you?
> 
> It doesn't seem to make any sense. I guess that on your platform
> /sys/kernel/debug/devices_deferred
> is not empty anymore?
> 
> Does your platform use Broadcom Ethernet controller at all?

I do not believe it does, however according to the log, the driver is 
enabled:

<6>[    1.819466] bgmac_bcma: Broadcom 47xx GBit MAC driver loaded

but it should not be probing any device since you don't have any 
internal BCMA bus to match gigabit devices with. Later in the log we see:

1c22c00.codec	sun4i-codec: Failed to register our card

and most likely as you already wrote the deferred device list might not 
be empty.
-- 
Florian