netdev - Re: [RFC PATCH v3 5/5] Convert Intel e1000e NIC driver to use ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230405121558.si5jstt4knmprarb@skbuf>
Date:   Wed, 5 Apr 2023 15:15:58 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Maxim Georgiev <glipus@...il.com>
Cc:     kory.maincent@...tlin.com, kuba@...nel.org, netdev@...r.kernel.org,
        maxime.chevallier@...tlin.com, vadim.fedorenko@...ux.dev,
        richardcochran@...il.com, gerhard@...leder-embedded.com
Subject: Re: [RFC PATCH v3 5/5] Convert Intel e1000e NIC driver to use
 ndo_hwtstamp_get/set callbacks

See "git log drivers/net/ethernet/intel/e1000e/netdev.c" for an example
of commit title formatting for this driver.

On Wed, Apr 05, 2023 at 12:33:38AM -0600, Maxim Georgiev wrote:
> This patch converts Intel·e1000e·NIC·driver·to·use

Strange symbols (·) instead of plain spaces here.

> the newly introduced ndo_hwtstamp_get/set functions to handle
> HW timestamp set and query requests instead of implementing
> SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs handling logic.
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Maxim Georgiev <glipus@...il.com>
> ---
> -static int e1000e_hwtstamp_get(struct net_device *netdev, struct ifreq *ifr)
> +static int e1000e_hwtstamp_get(struct net_device *netdev,
> +			       struct kernel_hwtstamp_config *kernel_config,
> +			       struct netlink_ext_ack *extack)
>  {
>  	struct e1000_adapter *adapter = netdev_priv(netdev);
>  
> -	return copy_to_user(ifr->ifr_data, &adapter->hwtstamp_config,
> -			    sizeof(adapter->hwtstamp_config)) ? -EFAULT : 0;
> +	hwtstamp_config_to_kernel(kernel_config, &adapter->hwtstamp_config);

Why don't you change the type of adapter->hwtstamp_config to struct
kernel_hwtstamp_config and work just with that?

> +	return 0;
>  }

Since AFAIU, none of the CCed people offered to test your patches on
e1000, I guess the options to make progress are either to CC some Intel
people, or to convert some other driver where a volunteer does exist.