netdev - Re: [RFC PATCH v3 4/5] Convert netdevsim driver to use ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230405121848.yojvkbms4cvfriec@skbuf>
Date:   Wed, 5 Apr 2023 15:18:48 +0300
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Maxim Georgiev <glipus@...il.com>
Cc:     kory.maincent@...tlin.com, kuba@...nel.org, netdev@...r.kernel.org,
        maxime.chevallier@...tlin.com, vadim.fedorenko@...ux.dev,
        richardcochran@...il.com, gerhard@...leder-embedded.com
Subject: Re: [RFC PATCH v3 4/5] Convert netdevsim driver to use
 ndo_hwtstamp_get/set for hw timestamp requests

On Wed, Apr 05, 2023 at 12:33:30AM -0600, Maxim Georgiev wrote:
> Changing netdevsim driver to use the newly introduced ndo_hwtstamp_get/set
> callback functions instead of implementing full-blown SIOCGHWTSTAMP/
> SIOCSHWTSTAMP IOCTLs handling logic.
> 
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Maxim Georgiev <glipus@...il.com>
> ---

The commit message describes a conversion, but this isn't a conversion,
it's new functionality (which to my eyes is also incomplete).

Also, what happened to:

| I'd vote to split netdevsim out, and it needs a selftest which
| exercises it under tools/testing/selftests/drivers/net/netdevsim/
| to get merged...

https://lore.kernel.org/netdev/20230403141918.3257a195@kernel.org/