netdev - Re: [RFC PATCH v3 4/5] Convert netdevsim driver to use ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP5jrPHSJv7Bi8r=BzzZgx5vjo1Y9eajZdRbfV7T603ZwEEJfw@mail.gmail.com>
Date:   Wed, 5 Apr 2023 10:35:43 -0600
From:   Max Georgiev <glipus@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     kory.maincent@...tlin.com, kuba@...nel.org, netdev@...r.kernel.org,
        maxime.chevallier@...tlin.com, vadim.fedorenko@...ux.dev,
        richardcochran@...il.com, gerhard@...leder-embedded.com
Subject: Re: [RFC PATCH v3 4/5] Convert netdevsim driver to use
 ndo_hwtstamp_get/set for hw timestamp requests

On Wed, Apr 5, 2023 at 6:18 AM Vladimir Oltean <vladimir.oltean@....com> wrote:
>
> On Wed, Apr 05, 2023 at 12:33:30AM -0600, Maxim Georgiev wrote:
> > Changing netdevsim driver to use the newly introduced ndo_hwtstamp_get/set
> > callback functions instead of implementing full-blown SIOCGHWTSTAMP/
> > SIOCSHWTSTAMP IOCTLs handling logic.
> >
> > Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Maxim Georgiev <glipus@...il.com>
> > ---
>
> The commit message describes a conversion, but this isn't a conversion,
> it's new functionality (which to my eyes is also incomplete).

That's true, the commit message is misleading, the patch misses the logic
allowing ethtool to read the timestamp config, and I still don't have test
results for this patch. I didn't get to it yet.
Let me do the right thing and drop patches 4/5 and 5/5 from the stack
temporarily until I get them right.

>
> Also, what happened to:
>
> | I'd vote to split netdevsim out, and it needs a selftest which
> | exercises it under tools/testing/selftests/drivers/net/netdevsim/
> | to get merged...
>
> https://lore.kernel.org/netdev/20230403141918.3257a195@kernel.org/