netdev - Re: [PATCH bpf-next 0/8] bpf: Follow up to RCU enforcement in the verifier.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bza6BgD2Dr=8M2daiPKBkytsOXHG7XbN=8jv68Tu3Bq1Fg@mail.gmail.com>
Date:   Wed, 5 Apr 2023 13:11:02 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        David Vernet <void@...ifault.com>,
        "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...nel.org>,
        Dave Marchevsky <davemarchevsky@...a.com>,
        Tejun Heo <tj@...nel.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Kernel Team <kernel-team@...com>,
        Yonghong Song <yhs@...a.com>, Song Liu <song@...nel.org>
Subject: Re: [PATCH bpf-next 0/8] bpf: Follow up to RCU enforcement in the verifier.

On Wed, Apr 5, 2023 at 11:19 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 5 Apr 2023 10:22:16 -0700 Andrii Nakryiko wrote:
> > So I'm exclusively using `pw-apply -c <patchworks-url>` to apply
> > everything locally.
>
> I think you can throw -M after -c $url? It can only help... :)
>
> > I'd expect that at this time the script would
> > detect any Acked-by replies on *cover letter patch*, and apply them
> > across all patches in the series. Such that we (humans) can look at
> > them, fix them, add them, etc. Doing something like this in git hook
> > seems unnecessary?
>
> Maybe mb2q can do it, IDK. I don't use the mb2q thing.
> I don't think git has a way of doing git am and insert these tags if
> they don't exist, in a single command.
>
> > So I think the only thing that's missing is the code that would fetch
> > all replies on the cover letter "patch" (e.g., like on [0]) and just
> > apply it across everything. We must be doing something like this for
> > acks on individual patches, so I imagine we are not far off to make
> > this work, but I haven't looked at pw-apply carefully enough to know
> > for sure.
>
> The individual patches are handled by patchwork.
>

Ah, I see, so yeah, it would be harder to do in pw-apply then.

> Don't get me wrong, I'm not disagreeing with you. Just trying to help
> and point out existing workarounds..

Oh, absolutely, I think we are all on the same page here. Daniel
mentioned -a in another reply, I didn't know about that and will use
that for the time being, still will save a bunch of time next time.

When I feel inspired to deal with a bit of bash, curl, and stuff, I'll
see if we can extend `pw-apply -c` to do this automatically. Thanks
for the discussion!