netdev - [PATCH net-next 1/3] ksz884x: remove commented-out #defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 05 Apr 2023 10:39:16 +0200
From:   Simon Horman <horms@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: [PATCH net-next 1/3] ksz884x: remove commented-out #defines

Remove commented-out #defines from ksz884x driver.
These are self-evidently unused.

These #defines may have some value in documenting the hardware.
But that information may be accessed via scm history.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Simon Horman <horms@...nel.org>
---
 drivers/net/ethernet/micrel/ksz884x.c | 33 ---------------------------------
 1 file changed, 33 deletions(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index f78e8ead8c36..f70895f2174e 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -583,15 +583,6 @@
 #define PORT_REMOTE_10BT_FD		0x0002
 #define PORT_REMOTE_10BT		0x0001
 
-/*
-#define STATIC_MAC_TABLE_ADDR		00-0000FFFF-FFFFFFFF
-#define STATIC_MAC_TABLE_FWD_PORTS	00-00070000-00000000
-#define STATIC_MAC_TABLE_VALID		00-00080000-00000000
-#define STATIC_MAC_TABLE_OVERRIDE	00-00100000-00000000
-#define STATIC_MAC_TABLE_USE_FID	00-00200000-00000000
-#define STATIC_MAC_TABLE_FID		00-03C00000-00000000
-*/
-
 #define STATIC_MAC_TABLE_ADDR		0x0000FFFF
 #define STATIC_MAC_TABLE_FWD_PORTS	0x00070000
 #define STATIC_MAC_TABLE_VALID		0x00080000
@@ -602,13 +593,6 @@
 #define STATIC_MAC_FWD_PORTS_SHIFT	16
 #define STATIC_MAC_FID_SHIFT		22
 
-/*
-#define VLAN_TABLE_VID			00-00000000-00000FFF
-#define VLAN_TABLE_FID			00-00000000-0000F000
-#define VLAN_TABLE_MEMBERSHIP		00-00000000-00070000
-#define VLAN_TABLE_VALID		00-00000000-00080000
-*/
-
 #define VLAN_TABLE_VID			0x00000FFF
 #define VLAN_TABLE_FID			0x0000F000
 #define VLAN_TABLE_MEMBERSHIP		0x00070000
@@ -617,17 +601,6 @@
 #define VLAN_TABLE_FID_SHIFT		12
 #define VLAN_TABLE_MEMBERSHIP_SHIFT	16
 
-/*
-#define DYNAMIC_MAC_TABLE_ADDR		00-0000FFFF-FFFFFFFF
-#define DYNAMIC_MAC_TABLE_FID		00-000F0000-00000000
-#define DYNAMIC_MAC_TABLE_SRC_PORT	00-00300000-00000000
-#define DYNAMIC_MAC_TABLE_TIMESTAMP	00-00C00000-00000000
-#define DYNAMIC_MAC_TABLE_ENTRIES	03-FF000000-00000000
-#define DYNAMIC_MAC_TABLE_MAC_EMPTY	04-00000000-00000000
-#define DYNAMIC_MAC_TABLE_RESERVED	78-00000000-00000000
-#define DYNAMIC_MAC_TABLE_NOT_READY	80-00000000-00000000
-*/
-
 #define DYNAMIC_MAC_TABLE_ADDR		0x0000FFFF
 #define DYNAMIC_MAC_TABLE_FID		0x000F0000
 #define DYNAMIC_MAC_TABLE_SRC_PORT	0x00300000
@@ -645,12 +618,6 @@
 #define DYNAMIC_MAC_ENTRIES_SHIFT	24
 #define DYNAMIC_MAC_ENTRIES_H_SHIFT	8
 
-/*
-#define MIB_COUNTER_VALUE		00-00000000-3FFFFFFF
-#define MIB_COUNTER_VALID		00-00000000-40000000
-#define MIB_COUNTER_OVERFLOW		00-00000000-80000000
-*/
-
 #define MIB_COUNTER_VALUE		0x3FFFFFFF
 #define MIB_COUNTER_VALID		0x40000000
 #define MIB_COUNTER_OVERFLOW		0x80000000

-- 
2.30.2