netdev - RE: [PATCH net-next v2 1/4] vlan: Add MACsec offload operations for VLAN interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR12MB6353C7F6A3CBFC62DC23AA89AB909@IA1PR12MB6353.namprd12.prod.outlook.com>
Date:   Wed, 5 Apr 2023 09:36:43 +0000
From:   Emeel Hakim <ehakim@...dia.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v2 1/4] vlan: Add MACsec offload operations for
 VLAN interface



> -----Original Message-----
> From: Sabrina Dubroca <sd@...asysnail.net>
> Sent: Wednesday, 5 April 2023 12:27
> To: Emeel Hakim <ehakim@...dia.com>
> Cc: davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com;
> edumazet@...gle.com; netdev@...r.kernel.org
> Subject: Re: [PATCH net-next v2 1/4] vlan: Add MACsec offload operations for
> VLAN interface
> 
> External email: Use caution opening links or attachments
> 
> 
> 2023-03-29, 15:21:04 +0300, Emeel Hakim wrote:
> > Add support for MACsec offload operations for VLAN driver to allow
> > offloading MACsec when VLAN's real device supports Macsec offload by
> > forwarding the offload request to it.
> >
> > Signed-off-by: Emeel Hakim <ehakim@...dia.com>
> > ---
> > V1 -> V2: - Consult vlan_features when adding NETIF_F_HW_MACSEC.
> >                 - Allow grep for the functions.
> >                 - Add helper function to get the macsec operation to allow the compiler
> to make some choice.
> >  .../net/ethernet/mellanox/mlx5/core/en_main.c |   1 +
> >  net/8021q/vlan_dev.c                          | 101 ++++++++++++++++++
> >  2 files changed, 102 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > index 6db1aff8778d..5ecef26e83c6 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > @@ -5076,6 +5076,7 @@ static void mlx5e_build_nic_netdev(struct
> > net_device *netdev)
> >
> >       netdev->vlan_features    |= NETIF_F_SG;
> >       netdev->vlan_features    |= NETIF_F_HW_CSUM;
> > +     netdev->vlan_features    |= NETIF_F_HW_MACSEC;
> >       netdev->vlan_features    |= NETIF_F_GRO;
> >       netdev->vlan_features    |= NETIF_F_TSO;
> >       netdev->vlan_features    |= NETIF_F_TSO6;
> 
> IMO that shouldn't be part of this patch. One patch for VLAN to add MACsec
> offload, then one for mlx5 to enable the feature.

I can split the patch into two patches and send all as new version, 
should It be as a new V3 (since last V3 got discarded) or I send as a V4? 

> --
> Sabrina