netdev - Re: [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZC/yJdo163Lc4EBU@corigine.com>
Date:   Fri, 7 Apr 2023 12:36:21 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Wei Yongjun <weiyongjun@...weicloud.com>
Cc:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Joseph CHAMG <josright123@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Shay Agroskin <shayagr@...zon.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Nathan Huckleberry <nhuck@...gle.com>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
        Wells Lu <wellslutw@...il.com>,
        Leon Romanovsky <leon@...nel.org>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: davicom: Make davicom drivers not depends
 on DM9000

On Fri, Apr 07, 2023 at 09:49:30AM +0000, Wei Yongjun wrote:
> [You don't often get email from weiyongjun@...weicloud.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> All davicom drivers build need CONFIG_DM9000 is set, but this dependence
> is not correctly since dm9051 can be build as module without dm9000, switch
> to using CONFIG_NET_VENDOR_DAVICOM instead.

Thanks, this seems correct to me.
And I was able to exercise it successfully.

Maybe this is appropriate?

Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")

> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>