netdev - Re: [PATCH net-next] net: davicom: Make davicom drivers not depends on DM9000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ca60e3606aa710ef3b98b759572fdd7bfd20c74.camel@redhat.com>
Date:   Tue, 11 Apr 2023 15:26:46 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Wei Yongjun <weiyongjun@...weicloud.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Joseph CHAMG <josright123@...il.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Simon Horman <simon.horman@...igine.com>,
        Shay Agroskin <shayagr@...zon.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Nathan Huckleberry <nhuck@...gle.com>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
        Wells Lu <wellslutw@...il.com>,
        Leon Romanovsky <leon@...nel.org>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: davicom: Make davicom drivers not depends
 on DM9000

On Fri, 2023-04-07 at 09:49 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> All davicom drivers build need CONFIG_DM9000 is set, but this dependence
> is not correctly since dm9051 can be build as module without dm9000, switch
> to using CONFIG_NET_VENDOR_DAVICOM instead.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/net/ethernet/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
> index 0d872d4efcd1..ee640885964e 100644
> --- a/drivers/net/ethernet/Makefile
> +++ b/drivers/net/ethernet/Makefile
> @@ -32,7 +32,7 @@ obj-$(CONFIG_NET_VENDOR_CIRRUS) += cirrus/
>  obj-$(CONFIG_NET_VENDOR_CISCO) += cisco/
>  obj-$(CONFIG_NET_VENDOR_CORTINA) += cortina/
>  obj-$(CONFIG_CX_ECAT) += ec_bhf.o
> -obj-$(CONFIG_DM9000) += davicom/
> +obj-$(CONFIG_NET_VENDOR_DAVICOM) += davicom/
>  obj-$(CONFIG_DNET) += dnet.o
>  obj-$(CONFIG_NET_VENDOR_DEC) += dec/
>  obj-$(CONFIG_NET_VENDOR_DLINK) += dlink/

Can you repost this for -net, including a suitable Fixes tag, as
suggested by Simon?

Thanks!

Paolo