netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: Correct cmode to PHY_INTERFACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <123b198a-f810-a096-137b-fcf433a13b96@gmail.com>
Date:   Tue, 11 Apr 2023 05:33:27 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Correct cmode to
 PHY_INTERFACE_



On 4/11/2023 4:38 AM, Vladimir Oltean wrote:
> On Tue, Apr 11, 2023 at 04:35:41AM +0200, Andrew Lunn wrote:
>> The switch can either take the MAC or the PHY role in an MII or RMII
>> link. There are distinct PHY_INTERFACE_ macros for these two roles.
>> Correct the mapping so that the `REV` version is used for the PHY
>> role.
>>
>> Signed-off-by: Andrew Lunn <andrew@...n.ch>
>> ---
> 
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> 
>>
>> Since this has not caused any known issues so far, i decided to not
>> add a Fixes: tag and submit for net.
>>
>>   drivers/net/dsa/mv88e6xxx/chip.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
>> index 62a126402983..ffe6a88f94ce 100644
>> --- a/drivers/net/dsa/mv88e6xxx/chip.c
>> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
>> @@ -611,10 +611,10 @@ static void mv88e6185_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
>>   }
>>   
>>   static const u8 mv88e6xxx_phy_interface_modes[] = {
>> -	[MV88E6XXX_PORT_STS_CMODE_MII_PHY]	= PHY_INTERFACE_MODE_MII,
>> +	[MV88E6XXX_PORT_STS_CMODE_MII_PHY]	= PHY_INTERFACE_MODE_REVMII,

Is this hunk correct?

>>   	[MV88E6XXX_PORT_STS_CMODE_MII]		= PHY_INTERFACE_MODE_MII,
>>   	[MV88E6XXX_PORT_STS_CMODE_GMII]		= PHY_INTERFACE_MODE_GMII,
>> -	[MV88E6XXX_PORT_STS_CMODE_RMII_PHY]	= PHY_INTERFACE_MODE_RMII,
>> +	[MV88E6XXX_PORT_STS_CMODE_RMII_PHY]	= PHY_INTERFACE_MODE_REVRMII,
>>   	[MV88E6XXX_PORT_STS_CMODE_RMII]		= PHY_INTERFACE_MODE_RMII,
>>   	[MV88E6XXX_PORT_STS_CMODE_100BASEX]	= PHY_INTERFACE_MODE_100BASEX,
>>   	[MV88E6XXX_PORT_STS_CMODE_1000BASEX]	= PHY_INTERFACE_MODE_1000BASEX,
>> -- 
>> 2.40.0
>>

-- 
Florian