netdev - Re: [PATCH net-next v2 6/6] net: txgbe: Support phylink MAC layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d810223e-1b56-450b-997a-d0cdf0d3974a@lunn.ch>
Date:   Tue, 11 Apr 2023 14:43:06 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org,
        mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v2 6/6] net: txgbe: Support phylink MAC layer

> > @@ -204,7 +205,7 @@ static int txgbe_request_irq(struct wx *wx)
> >  
> >  static void txgbe_up_complete(struct wx *wx)
> >  {
> > -	u32 reg;
> > +	struct txgbe *txgbe = (struct txgbe *)wx->priv;
> 
> Personal choice I guess, but normally we tend to rely on compilers
> accepting the implicit cast from void * to whatever struct pointer
> in the kernel.

Davem used to strongly push back against a cast when the pointer was a
void *. Please remove the cast.

     Andrew