lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8e36fa45-129c-4bb1-3ebb-1b0871355ef2@gmail.com> Date: Tue, 11 Apr 2023 06:00:48 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: Vladimir Oltean <vladimir.oltean@....com>, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Russell King <rmk+kernel@...linux.org.uk>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Correct cmode to PHY_INTERFACE_ On 4/11/2023 5:48 AM, Andrew Lunn wrote: >> On 4/11/2023 4:38 AM, Vladimir Oltean wrote: >>> On Tue, Apr 11, 2023 at 04:35:41AM +0200, Andrew Lunn wrote: >>>> The switch can either take the MAC or the PHY role in an MII or RMII >>>> link. There are distinct PHY_INTERFACE_ macros for these two roles. >>>> Correct the mapping so that the `REV` version is used for the PHY >>>> role. > >>>> static const u8 mv88e6xxx_phy_interface_modes[] = { >>>> - [MV88E6XXX_PORT_STS_CMODE_MII_PHY] = PHY_INTERFACE_MODE_MII, >>>> + [MV88E6XXX_PORT_STS_CMODE_MII_PHY] = PHY_INTERFACE_MODE_REVMII, >> >> Is this hunk correct? > > Hi Florian > > I don't see why it is wrong, but you can be blind to bugs in your own > code. What do you think is wrong? I was not thinking it was wrong, just curious about the meaning of a CMODE value suffixed with _PHY, though it seems clear(er) now that this means the port is configured as a PHY and provides PHY signals to the MAC it connects to. Reviewed-by: Florian Fainelli <f.fainelli@...il.com> PS: you can be blind without enough coffee as well :p -- Florian
Powered by blists - more mailing lists