lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230412141910.23d11026@kmaincent-XPS-13-7390> Date: Wed, 12 Apr 2023 14:19:10 +0200 From: Köry Maincent <kory.maincent@...tlin.com> To: Vladimir Oltean <vladimir.oltean@....com> Cc: Michael Walle <michael@...le.cc>, kuba@...nel.org, gerhard@...leder-embedded.com, glipus@...il.com, krzysztof.kozlowski+dt@...aro.org, linux@...linux.org.uk, maxime.chevallier@...tlin.com, netdev@...r.kernel.org, richardcochran@...il.com, robh+dt@...nel.org, thomas.petazzoni@...tlin.com, vadim.fedorenko@...ux.dev Subject: Re: [PATCH net-next RFC v4 2/5] net: Expose available time stamping layers to user space. On Wed, 12 Apr 2023 14:08:40 +0300 Vladimir Oltean <vladimir.oltean@....com> wrote: > On Wed, Apr 12, 2023 at 12:50:34PM +0200, Michael Walle wrote: > > >> +/* Hardware layer of the SO_TIMESTAMPING provider */ > > >> +enum timestamping_layer { > > >> + SOF_MAC_TIMESTAMPING =3D (1<<0), > > >> + SOF_PHY_TIMESTAMPING =3D (1<<1), > > > > > > What does SOF_ stand for? > > > > I'd guess start of frame. The timestamp will be taken at the > > beginning of the frame. > > I would suggest (with all due respect) that it was an inapt adaptation > of the Socket Option Flags that can be seen in > Documentation/networking/timestamping.rst. > > These are not socket option flags (because these settings are not per > socket), so the namespace/prefix is not really correctly used here. As Jakub said, who knows maybe one day it will be per socket information, but indeed for now it is not the case. I will stick to whatever name the community prefer.
Powered by blists - more mailing lists