netdev - Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230415142807.uzgznv7cklwbeyg7@skbuf>
Date:   Sat, 15 Apr 2023 17:28:07 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Daniel Golle <daniel@...rotopia.org>
Cc:     Arınç ÜNAL <arinc.unal@...nc9.com>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        netdev <netdev@...r.kernel.org>, erkin.bozoglu@...ont.com,
        Thibaut <hacks@...shdirt.org>
Subject: Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run
 twice

On Sat, Apr 15, 2023 at 05:20:14PM +0300, Vladimir Oltean wrote:
> On Sat, Apr 15, 2023 at 03:02:10PM +0100, Daniel Golle wrote:
> > As the PHYs are accessed over the MDIO bus which is exposed by the mt7530.c
> > DSA driver the only middle ground would possibly be to introduce a MFD
> > driver taking care of creating the bus access regmap (MDIO vs. MDIO) and
> > expose the mt7530-controlled MDIO bus.
> 
> Which is something I had already mentioned as a possible way forward in
> the other thread. One would need to take care of ensuring a reasonable
> migration path in terms of device tree compatibility though.

You mention the PHYs because you seem to suggest that the PHY muxing
code should go there. I think it would also be possible to just put it
in this new MFD parent driver of the DSA switch, which is in fact what
I had originally suggested.