netdev - Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Apr 2023 17:57:05 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Daniel Golle <daniel@...rotopia.org>
Cc:     Frank Wunderlich <frank-w@...lic-files.de>,
        netdev <netdev@...r.kernel.org>, erkin.bozoglu@...ont.com,
        Thibaut <hacks@...shdirt.org>
Subject: Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run
 twice

On 15.04.2023 17:20, Vladimir Oltean wrote:
> On Sat, Apr 15, 2023 at 03:02:10PM +0100, Daniel Golle wrote:
>> As the PHYs are accessed over the MDIO bus which is exposed by the mt7530.c
>> DSA driver the only middle ground would possibly be to introduce a MFD
>> driver taking care of creating the bus access regmap (MDIO vs. MDIO) and
>> expose the mt7530-controlled MDIO bus.
> 
> Which is something I had already mentioned as a possible way forward in
> the other thread. One would need to take care of ensuring a reasonable
> migration path in terms of device tree compatibility though.
> 
>>
>> Obviously that'd be a bit more work than just moving some things from the
>> switch setup function to the probe function...
> 
> On the other hand, it would actually work reliably, and would not depend
> on whomever wanted to reorder things just a little bit differently for
> his system to probe faster.

Ok thanks. I will investigate how the switch would be set up with an MFD 
driver, and how it would affect dt-bindings.

Looking back at my patch series, currently with this [0], SGMII on 
MT7531BE's port 6 starts working, and with Daniel's addition [1], the 
regulator warnings disappear.

I will submit the patch series as an RFC after addressing Daniel's 
inline functions suggestion.

[0] 
https://github.com/arinc9/linux/commit/89230fc01c86ec7e6b8a43a7f54ba8db97aaa4cd
[1] 
https://github.com/dangowrt/linux/commit/55035b5ac739914166ed4f026262d0fc9b17bc76

Arınç