netdev - Re: [PATCH net-next 2/5] net: wangxun: libwx add rx offload functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b4ec1acd-8013-4f90-a4a4-8a1336c457d2@lunn.ch>
Date:   Sat, 15 Apr 2023 16:52:58 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Mengyuan Lou <mengyuanlou@...-swift.com>
Cc:     netdev@...r.kernel.org, jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next 2/5] net: wangxun: libwx add rx offload functions

> +#ifdef NAPI_GRO_CB
> +		NAPI_GRO_CB(skb)->data_offset = 0;
> +#endif

https://elixir.bootlin.com/linux/latest/source/include/net/gro.h#L85

NAPI_GRO_CB does not seem to be conditional. Why the #ifdef ?

> +		skb_shinfo(skb)->gso_size = WX_CB(skb)->mss;

I have to question how safe this is:

#define NAPI_GRO_CB(skb) ((struct napi_gro_cb *)(skb)->cb)
#define WX_CB(skb) ((struct wx_cb *)(skb)->cb)

So they are both referring to the same bit of memory.

Does the design take this into account?

     Andrew