netdev - Re: [PATCHv2 net] net: rpl: fix rpl header size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK-6q+iLvka6M7ag4ATMP40Cn+zetVW60XW+4kpn8HGZ=bnXKQ@mail.gmail.com>
Date:   Mon, 17 Apr 2023 12:24:07 -0400
From:   Alexander Aring <aahringo@...hat.com>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, alex.aring@...il.com,
        daniel@...earbox.net, ymittal@...hat.com, mcascell@...hat.com,
        torvalds@...uxfoundation.org, mcr@...delman.ca,
        maxpl0it@...tonmail.com
Subject: Re: [PATCHv2 net] net: rpl: fix rpl header size calculation

Hi,

On Mon, Apr 17, 2023 at 9:09 AM Alexander Aring <aahringo@...hat.com> wrote:
>
> This patch fixes a missing 8 byte for the header size calculation. The
> ipv6_rpl_srh_size() is used to check a skb_pull() on skb->data which
> points to skb_transport_header(). Currently we only check on the
> calculated addresses fields using CmprI and CmprE fields, see:
>
> https://www.rfc-editor.org/rfc/rfc6554#section-3
>
> there is however a missing 8 byte inside the calculation which stands
> for the fields before the addresses field. Those 8 bytes are represented
> by sizeof(struct ipv6_rpl_sr_hdr) expression.
>
> Fixes: 8610c7c6e3bd ("net: ipv6: add support for rpl sr exthdr")
> Signed-off-by: Alexander Aring <aahringo@...hat.com>

Reported-by: maxpl0it <maxpl0it@...tonmail.com>

I just got this information. Thanks for reporting it.

- Alex