netdev - Re: [PATCHv2 net] net: rpl: fix rpl header size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f04d922e-c872-b6ab-32b6-4452cb34890b@kernel.org>
Date:   Mon, 17 Apr 2023 11:51:11 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Alexander Aring <aahringo@...hat.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, alex.aring@...il.com, daniel@...earbox.net,
        ymittal@...hat.com, mcascell@...hat.com,
        torvalds@...uxfoundation.org, mcr@...delman.ca
Subject: Re: [PATCHv2 net] net: rpl: fix rpl header size calculation

On 4/17/23 7:00 AM, Alexander Aring wrote:
> This patch fixes a missing 8 byte for the header size calculation. The
> ipv6_rpl_srh_size() is used to check a skb_pull() on skb->data which
> points to skb_transport_header(). Currently we only check on the
> calculated addresses fields using CmprI and CmprE fields, see:
> 
> https://www.rfc-editor.org/rfc/rfc6554#section-3
> 
> there is however a missing 8 byte inside the calculation which stands
> for the fields before the addresses field. Those 8 bytes are represented
> by sizeof(struct ipv6_rpl_sr_hdr) expression.
> 
> Fixes: 8610c7c6e3bd ("net: ipv6: add support for rpl sr exthdr")
> Signed-off-by: Alexander Aring <aahringo@...hat.com>
> ---
> changes since v2:
>  - use sizeof(struct ipv6_rpl_sr_hdr) instead of hardcoded 8
> 
>  net/ipv6/rpl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>