netdev - Re: [PATCH v8 vfio 3/7] vfio/pds: register with the pds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36a04310-0ec0-58fb-ef09-5495d3495d5e@amd.com>
Date:   Mon, 17 Apr 2023 11:42:50 -0700
From:   Shannon Nelson <shannon.nelson@....com>
To:     Jason Gunthorpe <jgg@...dia.com>,
        Brett Creeley <brett.creeley@....com>
Cc:     kvm@...r.kernel.org, netdev@...r.kernel.org,
        alex.williamson@...hat.com, yishaih@...dia.com,
        shameerali.kolothum.thodi@...wei.com, kevin.tian@...el.com,
        drivers@...sando.io, simon.horman@...igine.com
Subject: Re: [PATCH v8 vfio 3/7] vfio/pds: register with the pds_core PF

On 4/14/23 5:43 AM, Jason Gunthorpe wrote:
> 
> On Tue, Apr 04, 2023 at 12:01:37PM -0700, Brett Creeley wrote:
>> @@ -30,13 +34,23 @@ pds_vfio_pci_probe(struct pci_dev *pdev,
>>
>>        dev_set_drvdata(&pdev->dev, &pds_vfio->vfio_coredev);
>>        pds_vfio->pdev = pdev;
>> +     pds_vfio->pdsc = pdsc_get_pf_struct(pdev);
> 
> This should not be a void *, it has a type, looks like it is 'struct
> pdsc *' - comment applies to all the places in both series that
> dropped the type here.

Thanks, Jason.  I'll fix this up with a proper type in the pds_core 
patchset so that the pds_vfio can follow.

sln