netdev - Re: [PATCHv4 net-next] bonding: add software tx timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230417114710.57ae73ea@kernel.org>
Date:   Mon, 17 Apr 2023 11:47:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Jay Vosburgh <jay.vosburgh@...onical.com>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Liang Li <liali@...hat.com>,
        Simon Horman <simon.horman@...igine.com>,
        Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [PATCHv4 net-next] bonding: add software tx timestamping
 support

On Mon, 17 Apr 2023 08:17:39 +0800 Hangbin Liu wrote:
> I remember why I use bond_for_each_slave_rcu() here now. In commit
> 9b80ccda233f ("bonding: fix missed rcu protection"), I added the
> rcu_read_lock() as syzbot reported[1] the following path doesn't hold
> rtnl lock.
> - sock_setsockopt
>   - sock_set_timestamping
>     - sock_timestamping_bind_phc
>       - ethtool_get_phc_vclocks
>         - __ethtool_get_ts_info
> 	  - bond_ethtool_get_ts_info

Well spotted, okay :(
Could you respin with this info added to the commit message and an
update to the kdoc in include/linux/ethtool.h for @get_ts_info
that it may be called with RCU, or rtnl or reference on the device?