netdev - Re: [PATCH net-next] xsk: introduce xsk_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230417181950.5db68526@kernel.org>
Date:   Mon, 17 Apr 2023 18:19:50 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jason Wang <jasowang@...hat.com>
Cc:     Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Christoph Hellwig <hch@...radead.org>, netdev@...r.kernel.org,
        Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>, bpf@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Gerd Hoffmann <kraxel@...hat.com>
Subject: Re: [PATCH net-next] xsk: introduce xsk_dma_ops

On Tue, 18 Apr 2023 09:07:30 +0800 Jason Wang wrote:
> > > Would you mind explaining this a bit more to folks like me who are not
> > > familiar with VirtIO?  DMA API is supposed to hide the DMA mapping
> > > details from the stack, why is it not sufficient here.  
> 
> The reason is that legacy virtio device don't use DMA(vring_use_dma_api()).
> 
> The AF_XDP assumes DMA for netdev doesn't work in this case. We need a
> way to make it work.

Can we not push this down to be bus level? virtio has its own bus it
can plug in whatever magic it wants into dma ops.

Doesn't have to be super fast for af_xdp's sake - for af_xdp dma mapping
is on the control path. You can keep using the if (vring_use_dma_api())
elsewhere for now if there is a perf concern.

Otherwise it really seems like we're bubbling up a virtio hack into
generic code :(