netdev - RE: [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Apr 2023 08:03:56 +0000
From:   Emeel Hakim <ehakim@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "sd@...asysnail.net" <sd@...asysnail.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>
Subject: RE: [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, 19 April 2023 3:36
> To: Emeel Hakim <ehakim@...dia.com>
> Cc: davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com;
> sd@...asysnail.net; netdev@...r.kernel.org; leon@...nel.org
> Subject: Re: [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN
> 
> External email: Use caution opening links or attachments
> 
> 
> On Tue, 18 Apr 2023 11:31:00 +0300 Emeel Hakim wrote:
> > +static inline struct mlx5e_priv *macsec_netdev_priv(const struct
> > +net_device *dev)
> 
> Does the compiler really not inline this without the explicit inline keyword?

I will remove it to let the compiler make its own decisions.

> > +{
> > +#if defined(CONFIG_VLAN_8021Q) ||
> defined(CONFIG_VLAN_8021Q_MODULE)
> 
> That's what IS_ENABLED() is for

ACK, I can replace it with #if IS_ENABLED(CONFIG_VLAN_8021Q)

> > +     if (is_vlan_dev(dev))
> > +             return netdev_priv(vlan_dev_priv(dev)->real_dev);
> > +#endif
> > +     return netdev_priv(dev);
> > +}
> 
> --
> pw-bot: cr