netdev - Re: [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230418173603.5b41e2e0@kernel.org>
Date:   Tue, 18 Apr 2023 17:36:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Emeel Hakim <ehakim@...dia.com>
Cc:     <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        <sd@...asysnail.net>, <netdev@...r.kernel.org>, <leon@...nel.org>
Subject: Re: [PATCH net-next v6 3/5] net/mlx5: Support MACsec over VLAN

On Tue, 18 Apr 2023 11:31:00 +0300 Emeel Hakim wrote:
> +static inline struct mlx5e_priv *macsec_netdev_priv(const struct net_device *dev)

Does the compiler really not inline this without the explicit inline
keyword?

> +{
> +#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)

That's what IS_ENABLED() is for

> +	if (is_vlan_dev(dev))
> +		return netdev_priv(vlan_dev_priv(dev)->real_dev);
> +#endif
> +	return netdev_priv(dev);
> +}

--
pw-bot: cr