netdev - RE: [PATCH net v2] ipv4: Fix potential uninit variable access buf in __ip_make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <643ff45fa94df_3834752945f@willemb.c.googlers.com.notmuch>
Date:   Wed, 19 Apr 2023 10:02:07 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Ziyang Xuan <william.xuanziyang@...wei.com>, davem@...emloft.net,
        dsahern@...nel.org, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: RE: [PATCH net v2] ipv4: Fix potential uninit variable access buf in
 __ip_make_skb()

Ziyang Xuan wrote:
> Like commit ea30388baebc ("ipv6: Fix an uninit variable access bug in
> __ip6_make_skb()"). icmphdr does not in skb linear region under the
> scenario of SOCK_RAW socket. Access icmp_hdr(skb)->type directly will
> trigger the uninit variable access bug.
> 
> Use a local variable icmp_type to carry the correct value in different
> scenarios.
> 
> Fixes: 96793b482540 ("[IPV4]: Add ICMPMsgStats MIB (RFC 4293)")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>