netdev - Re: [PATCH net-next v3 2/3] net: flower: add support for matching cfm fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2slqz5vg3bxj6k3fkvrjeyyuur3uoqce7hcuuav3siqgsnccex@prvv3iixeavl>
Date:   Wed, 19 Apr 2023 16:51:49 +0200
From:   Zahari Doychev <zahari.doychev@...ux.com>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, hmehrtens@...linear.com,
        aleksander.lobakin@...el.com,
        Zahari Doychev <zdoychev@...linear.com>
Subject: Re: [PATCH net-next v3 2/3] net: flower: add support for matching
 cfm fields

On Wed, Apr 19, 2023 at 04:40:33PM +0200, Simon Horman wrote:
> On Mon, Apr 17, 2023 at 11:32:32PM +0200, Zahari Doychev wrote:
> > From: Zahari Doychev <zdoychev@...linear.com>
> > 
> > Add support to the tc flower classifier to match based on fields in CFM
> > information elements like level and opcode.
> > 
> > tc filter add dev ens6 ingress protocol 802.1q \
> > 	flower vlan_id 698 vlan_ethtype 0x8902 cfm mdl 5 op 46 \
> > 	action drop
> > 
> > Signed-off-by: Zahari Doychev <zdoychev@...linear.com>
> 
> ...
> 
> > +static int fl_dump_key_cfm(struct sk_buff *skb,
> > +			   struct flow_dissector_key_cfm *key,
> > +			   struct flow_dissector_key_cfm *mask)
> > +{
> > +	struct nlattr *opts;
> > +	int err;
> > +	u8 mdl;
> > +
> > +	if (!memchr_inv(mask, 0, sizeof(mask)))
> 
> Perhaps this should be sizeof(*mask)
> 
> With that fixed feel free to add,
> 
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> 

Thanks, will do and resend.

...