netdev - Re: [PATCH] drivers/net/phy: add driver for Microchip LAN867x 10BASE-T1S PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Apr 2023 17:10:07 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Parthiban.Veerasooran@...rochip.com
Cc:     ramon.nordin.rodriguez@...roamp.se, hkallweit1@...il.com,
        linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
        Jan.Huber@...rochip.com, Horatiu.Vultur@...rochip.com,
        Woojung.Huh@...rochip.com
Subject: Re: [PATCH] drivers/net/phy: add driver for Microchip LAN867x
 10BASE-T1S PHY

On Wed, Apr 19, 2023 at 02:40:29PM +0000, Parthiban.Veerasooran@...rochip.com wrote:
> Hi Ramon,
> 
> Good day...! This is Parthiban from Microchip.
> 
> Thanks for your patches for the Microchip LAN867x 10BASE-T1S PHY. We 
> really appreciate your effort on this.
> 
> For your kind information, we are already working for the driver which 
> supports all the 10BASE-T1S PHYs from Microchip and doing internal 
> review of those driver patches to mainline. These patches are going to 
> reach mainline in couple of days. It is very unfortunate that we two are 
> working on the same task at the same time without knowing each other.
> 
> The architecture of your patch is similar to our current implementation. 
> However to be able to support also the upcoming 10BASE-T1S products 
> e.g., the LAN865x 10BASE-T1S MAC-PHY, additional functionalities have to 
> be implemented. In order to avoid unnecessary/redundant work on both 
> sides, we would like to collaborate with you on this topic and have a 
> sync outside of this mailing list before going forward.

Hi Parthiban

Please review version 2 of the patch which was posted today.  Is there
anything in that patch which is actually wrong?

I don't like the idea of dropping a patch, because a vendor comes out
of, maybe unintentional, stealth mode, and asks for their version to
be used, not somebody else's. For me this is especially important for
a new contributor.

My preferred way forward is to merge Ramon's code, and then you can
build on it with additional features to support other family
members.

Please don't get me wrong, i find it great you are supporting your own
devices. Not many vendors do. But Linux is a community, we have to
respect each others work, other members of the community.

	Andrew

FYI: Do you have any other drivers in the pipeline you want to
announce, just to avoid this happening again.