netdev - RE: [PATCH net v2] nfp: correct number of MSI vectors requests returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36322e3475804855a28c7e91a7ccdf3e@AcuMS.aculab.com>
Date:   Wed, 19 Apr 2023 15:37:57 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Louis Peens' <louis.peens@...igine.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC:     Leon Romanovsky <leon@...nel.org>,
        Simon Horman <simon.horman@...igine.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "oss-drivers@...igine.com" <oss-drivers@...igine.com>
Subject: RE: [PATCH net v2] nfp: correct number of MSI vectors requests
 returned

From: Louis Peens
> Sent: 19 April 2023 09:15
> 
> From: Xiaoyu Li <xiaoyu.li@...igine.com>
> 
> Before the referenced commit, if fewer interrupts are supported by
> hardware than requested, then pci_msix_vec_count() returned the
> former. However, after the referenced commit, an error is returned
> for this condition. This causes a regression in the NFP driver
> preventing probe from completing.

I believe the relevant change to the msix vector allocation
function has been reverted.
(Or at least, the over-zealous check of nvec removed.)

So this change to bound the number of interrupts
isn't needed.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)