netdev - Re: [PATCHv5 net-next] bonding: add software tx timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZD+EYi4zKj4qlj8z@Laptop-X1>
Date:   Wed, 19 Apr 2023 14:04:18 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Liang Li <liali@...hat.com>,
        Simon Horman <simon.horman@...igine.com>,
        Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [PATCHv5 net-next] bonding: add software tx timestamping support

On Tue, Apr 18, 2023 at 09:17:46PM -0700, Jakub Kicinski wrote:
> On Wed, 19 Apr 2023 12:09:17 +0800 Hangbin Liu wrote:
> > > I'll apply Jay's ack from v4 since these are not substantial changes.
> > > Thanks!  
> > 
> > Sorry, not sure if I missed something. bond_ethtool_get_ts_info() could be
> > called without RTNL. And we have ASSERT_RTNL() in v4.
> 
> Are there any documented best practices on when to keep an ack?
> I'm not aware of such a doc, it's a bit of a gray zone.
> IMHO the changes here weren't big enough to drop Jay's tag.

I don't know either. Some times I also struggle on whether I should keep the
ack tag, then I drop the tag just in case the reviewer doesn't agree with my
change.

Anyway, thanks a lot for your patient review and comments.

Regards
Hangbin