netdev - Re: [PATCH v2 1/1] net: macb: Shorten max_tx_len to 4KiB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230419180222.07d78b8a@kernel.org>
Date:   Wed, 19 Apr 2023 18:02:22 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     daire.mcnamara@...rochip.com, nicholas.ferre@...rochip.com,
        claudiu.beznea@...rochip.com, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org,
        conor.dooley@...rochip.com
Subject: Re: [PATCH v2 1/1] net: macb: Shorten max_tx_len to 4KiB - 56 on
 mpfs

On Tue, 18 Apr 2023 16:28:25 +0200 Simon Horman wrote:
> no need to refresh the patch on my account.
> But can the above be simplified as:
> 
>                if (macb_is_gem(bp) && hw_is_gem(bp->regs, bp->native_io))
>                        bp->max_tx_length = macb_config->max_tx_length;
>                else
>                        bp->max_tx_length = MACB_MAX_TX_LEN;

I suspect that DaveM agreed, because patch is set to Changes Requested
in patchwork :) 

Daire, please respin with Simon's suggestion.