netdev - Re: [RFC PATCH v3 1/5] Add NDOs for hardware timestamp get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP5jrPFytnMku6TQNFQGBh4-=mL0z3XVq7ofY1z3LPYMP7_G0Q@mail.gmail.com>
Date:   Thu, 20 Apr 2023 12:04:06 -0600
From:   Max Georgiev <glipus@...il.com>
To:     Köry Maincent <kory.maincent@...tlin.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>, kuba@...nel.org,
        netdev@...r.kernel.org, maxime.chevallier@...tlin.com,
        vadim.fedorenko@...ux.dev, richardcochran@...il.com,
        gerhard@...leder-embedded.com
Subject: Re: [RFC PATCH v3 1/5] Add NDOs for hardware timestamp get/set

On Thu, Apr 20, 2023 at 8:16 AM Köry Maincent <kory.maincent@...tlin.com> wrote:
>
> On Wed, 5 Apr 2023 09:54:27 -0600
> Max Georgiev <glipus@...il.com> wrote:
>
> > On Wed, Apr 5, 2023 at 6:31 AM Vladimir Oltean <vladimir.oltean@....com>
> > wrote:
> > >
> > > On Wed, Apr 05, 2023 at 12:31:44AM -0600, Maxim Georgiev wrote:
> > > > Current NIC driver API demands drivers supporting hardware timestamping
> > > > to implement handling logic for SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs.
> > > > Handling these IOCTLs requires dirivers to implement request parameter
> > > > structure translation between user and kernel address spaces, handling
> > > > possible translation failures, etc. This translation code is pretty much
> > > > identical across most of the NIC drivers that support SIOCGHWTSTAMP/
> > > > SIOCSHWTSTAMP.
> > > > This patch extends NDO functiuon set with ndo_hwtstamp_get/set
> > > > functions, implements SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTL translation
> > > > to ndo_hwtstamp_get/set function calls including parameter structure
> > > > translation and translation error handling.
> > > >
> > > > This patch is sent out as RFC.
> > > > It still pending on basic testing.
>
>
> Just wondering about the status of this patch series.
> Do you want hardware testing before v4?
> As there were several reviews, I was waiting for the next version before doing
> any testing but if you ask for it to move forward I can deal with it.
> Also, I have cadence macb MAC which supports time stamping, I can adapt your
> last patch on e1000e to macb driver but I would appreciate if you do it
> beforehand.

I've updated the patches in the stack based on the feedback you folks
kindly shared
for v3. I'm currently testing the combination of the changes in
dev_ioctl.c and netdevsim
driver changes - almost done with that. Let me finish this testing,
then update the patch
descriptions, and I'll be ready to send it out for review.

Regarding e1000e conversion patch: I don't have access to any NICs
with hw timestamping
support. I was going to drop the e1000e patch from v4 unless someone volunteered
to test it on real hardware. But that will have to wait till the rest
of the stack is reviewed and
at least preliminary accepted, right?