netdev - Re: [PATCH net-next 5/5] net: optimize napi_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d84e9f5056c4945cb4cfcc68c89986d3094b95b7.camel@redhat.com>
Date:   Fri, 21 Apr 2023 15:09:58 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 5/5] net: optimize napi_threaded_poll() vs
 RPS/RFS

Hello,

thank you for the extremely fast turnaround!

On Fri, 2023-04-21 at 09:43 +0000, Eric Dumazet wrote:
> We use napi_threaded_poll() in order to reduce our softirq dependency.
> 
> We can add a followup of 821eba962d95 ("net: optimize napi_schedule_rps()")
> to further remove the need of firing NET_RX_SOFTIRQ whenever
> RPS/RFS are used.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  include/linux/netdevice.h |  3 +++
>  net/core/dev.c            | 12 ++++++++++--
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index a6a3e9457d6cbc9fcbbde96b43b4b21878495403..08fbd4622ccf731daaee34ad99773d6dc2e82fa6 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -3194,7 +3194,10 @@ struct softnet_data {
>  #ifdef CONFIG_RPS
>  	struct softnet_data	*rps_ipi_list;
>  #endif
> +
>  	bool			in_net_rx_action;
> +	bool			in_napi_threaded_poll;

If I'm correct only one of the above 2 flags can be set to true at any
give time. I'm wondering if could use a single flag (possibly with a
rename - say 'in_napi_polling')?

Otherwise LGTM, many thanks!

Paolo