netdev - Re: [PATCH net-next 5/5] net: optimize napi_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230421070559.36a3e6a0@kernel.org>
Date:   Fri, 21 Apr 2023 07:05:59 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        eric.dumazet@...il.com
Subject: Re: [PATCH net-next 5/5] net: optimize napi_threaded_poll() vs
 RPS/RFS

On Fri, 21 Apr 2023 15:09:58 +0200 Paolo Abeni wrote:
> >  #endif
> > +
> >  	bool			in_net_rx_action;
> > +	bool			in_napi_threaded_poll;  
> 
> If I'm correct only one of the above 2 flags can be set to true at any
> give time. I'm wondering if could use a single flag (possibly with a
> rename - say 'in_napi_polling')?
> 
> Otherwise LGTM, many thanks!

No strong feelings either way but FWIW my intuition would be that it's
less confusing to keep the two separate (there seems to be no cost to
it at this point) 🤷️