netdev - Re: [PATCH net v2] net/sched: sch_fq: fix integer overflow of "credit"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0acecb6-6af7-9353-e3ed-cef69a88d4f2@mojatatu.com>
Date:   Fri, 21 Apr 2023 11:24:07 -0300
From:   Pedro Tammela <pctammela@...atatu.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Davide Caratti <dcaratti@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] net/sched: sch_fq: fix integer overflow of
 "credit"

On 20/04/2023 20:24, Jakub Kicinski wrote:
> On Thu, 20 Apr 2023 13:25:33 -0300 Pedro Tammela wrote:
>>>            "id": "9398",
>>>            "name": "Create FQ with maxrate setting",
>>
>> You probably don't want to backport the test as well? If so I would
>> break this patch into two.
> 
> IIRC the preference of stable folks is to backport more not fewer
> selftests. Practicality of that aside, I think the patch is good as is.

My concern here was mostly due to conflicts with the tdc code base. 
Davide explained to me privately that he will take care of this so it's 
all good.