netdev - Re: [PATCH net v2] net/sched: sch_fq: fix integer overflow of "credit"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2023 17:58:07 +0200
From:   Davide Caratti <dcaratti@...hat.com>
To:     Pedro Tammela <pctammela@...atatu.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] net/sched: sch_fq: fix integer overflow of "credit"

hi,

On Fri, Apr 21, 2023 at 4:24 PM Pedro Tammela <pctammela@...atatu.com> wrote:
>
> On 20/04/2023 20:24, Jakub Kicinski wrote:

[...]

> > IIRC the preference of stable folks is to backport more not fewer
> > selftests. Practicality of that aside, I think the patch is good as is.
>
> My concern here was mostly due to conflicts with the tdc code base.
> Davide explained to me privately that he will take care of this so it's
> all good.

right, and I should color this reply-to-all button in a way that
catches better my attention :)

the tdc code will be a merge conflict on kernels that don't have [1]
(v6.0 and v5.x), so I will skip the tdc testcase for the stable
backport (unless somebody has objections).

thanks,
-- 
davide

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=9e274718cc050874761