netdev - Re: [PATCH net-next v3 0/6] tsnep: XDP socket zero-copy support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5d3638a-f1f3-f45f-1b0c-e5de54dd07d1@engleder-embedded.com>
Date:   Fri, 21 Apr 2023 21:05:10 +0200
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
        kuba@...nel.org, edumazet@...gle.com, pabeni@...hat.com,
        bjorn@...nel.org, magnus.karlsson@...el.com,
        jonathan.lemon@...il.com
Subject: Re: [PATCH net-next v3 0/6] tsnep: XDP socket zero-copy support

On 20.04.23 22:19, Maciej Fijalkowski wrote:
> On Tue, Apr 18, 2023 at 09:04:53PM +0200, Gerhard Engleder wrote:
>> Implement XDP socket zero-copy support for tsnep driver. I tried to
>> follow existing drivers like igc as far as possible. But one main
>> difference is that tsnep does not need any reconfiguration for XDP BPF
>> program setup. So I decided to keep this behavior no matter if a XSK
>> pool is used or not. As a result, tsnep starts using the XSK pool even
>> if no XDP BPF program is available.
>>
>> Another difference is that I tried to prevent potentially failing
>> allocations during XSK pool setup. E.g. both memory models for page pool
>> and XSK pool are registered all the time. Thus, XSK pool setup cannot
>> end up with not working queues.
>>
>> Some prework is done to reduce the last two XSK commits to actual XSK
>> changes.
> 
> I had minor comments on two last patches, besides:
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

I will add that tag to all commits.

Thank you for the review!

Gerhard