netdev - Re: [PATCH v2 iproute2-next 00/10] Add tc-mqprio and tc-taprio support for preemptible traffic classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Apr 2023 10:14:01 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH v2 iproute2-next 00/10] Add tc-mqprio and tc-taprio
 support for preemptible traffic classes

On 4/18/23 5:39 AM, Vladimir Oltean wrote:
> This is the iproute2 support for the tc program to make use of the
> kernel features added in commit f7d29571ab0a ("Merge branch
> 'add-kernel-tc-mqprio-and-tc-taprio-support-for-preemptible-traffic-classes'").
> 
> The state of the man pages prior to this work was a bit unsatisfactory,
> so patches 03-07 contain some man page cleanup in tc-taprio(8) and
> tc-mqprio(8).

Thanks for updating the man pages. These should go through main first; I
can sync to main after those are applied and before your set if needed.


> 
> I don't know exactly what's the deal with syncing the main branch
> between iproute2.git and iproute2-next.git. This patch set applies on
> top of today's iproute2-next.git main branch, *merged* with today's
> iproute2.git main branch. If I had formatted it directly on
> iproute2-next, patch 04 would have conflicted with iproute2 change
> ce4068f22db4 ("man: tc-mqprio: extend prio-tc-queue mapping with
> examples"). I would recommend merging the 2 trees before applying this
> series to iproute2-next.

I merge main from time to time; just did that ...

> 
> It may be desirable for patches 01-06 to go to iproute2.git, so I've
> sorted those to be first, in order to make that possible.
> 
> I also dared to sync the kernel headers and provide a commit (07/10) in
> the same form as David Ahern does it. The automated script was:
> 
>   #!/bin/bash
> 
>   UAPI_FOLDER=include/uapi/
>   # Built with "make -j 8 headers_install O=headers"
>   KERNEL_HEADERS=/opt/net-next/headers/usr/include
> 
>   for file in $(find ${UAPI_FOLDER} -type f); do
>   	filename="${file##$UAPI_FOLDER}"
>   	rsync -avr "$KERNEL_HEADERS/$filename" "$file"
>   done

... and updated headers.

Repost the patches as 2 sets with the man page fixes targeted at main
and the new preemptible work for -next.